Merged
Conversation
Steveb-p
approved these changes
Mar 30, 2026
alongosz
approved these changes
Mar 30, 2026
| $orderedImportsFixer = new OrderedImportsFixer(); | ||
| $orderedImportsFixer->configure($orderedImportsRule); | ||
|
|
||
| /** @var list<FixerInterface> $fixers */ |
Member
There was a problem hiding this comment.
lists are PHPStan-specific
Suggested change
| /** @var list<FixerInterface> $fixers */ | |
| /** @phpstan-var list<FixerInterface> $fixers */ |
konradoboza
approved these changes
Mar 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
This PR makes the ordered imports behavior explicit in the Ibexa code style preset. Instead of relying on the upstream default configuration of
ordered_imports, the preset now defines the intended import grouping order directly, so class, function, and const imports are grouped consistently, and each group is sorted alphabetically. This avoids behavior changes caused by future php-cs-fixer default changes.For example, input like:
is now expected to be formatted as:
The PR also strengthens test coverage by adding a regression test for grouped imports and running the same expectations against both Ibexa46RuleSet and Ibexa50RuleSet.
For QA:
Documentation: